Smbd crash while closing connection

[Shilpa K]

I commented out "delete share command" from smb.conf and tried stopping the
share from MMC. It failed with "access denied". I notice that in the code,
"ACCESS_DENIED" is returned if "delete share command" is not specified:


WERROR _srvsvc_NetShareDel(struct pipes_struct *p,
                           struct srvsvc_NetShareDel *r)
{
....
....
        if (!lp_delete_share_cmd() || !*lp_delete_share_cmd()) {
                DEBUG(10,("_srvsvc_NetShareDel: No delete share
command\n"));
                return WERR_ACCESS_DENIED;
...
...
}

Also in the Samba master git, in the routine close_cnum(), yield_connection()
is not present. So, there may be changes in the master as compared to 3.6.

Thanks,
Shilpa


On Sat, Feb 28, 2015 at 6:42 AM, Richard Sharpe <realrichardsharpe at gmail.com
> wrote:

> On Fri, Feb 27, 2015 at 8:04 AM, Volker Lendecke
> <Volker.Lendecke at sernet.de> wrote:
> > On Fri, Feb 27, 2015 at 07:57:44AM -0800, Richard Sharpe wrote:
> >> On Fri, Feb 27, 2015 at 3:50 AM, Shilpa K <
> shilpa.krishnareddy at gmail.com> wrote:
> >> >>> Can you reproduce this with 4.x, or is this a 3.x-only bug ?
> >> >
> >> > As I do not have a system running 4.x versions, it will be difficult
> for me
> >> > to check if this problem exists on 4.x versions.
> >> >
> >> >>> Do you have any special setup to remove the share, i.e. a
> >> > "delete share command"?
> >> >
> >> > Yes, we do have a "delete share command" entry in smb.conf
> >>
> >> Is it possible that this is interacting in some way and causing the
> problem?
> >
> > Yes, of course it is. I can literally see how it's crashing,
> > but the fix is not really easy.
>
> This problem does not occur with the Samba Master branch without a
> delete share command. I have not tested with a delete share command.
>
> --
> Regards,
> Richard Sharpe
> (何以解憂？唯有杜康。--曹操)
>