[PATCH] [REVERT] Re: selftest: re-enable nss_winbind via nss_wrapper in the test-envs.

[Andrew Bartlett]

On Thu, 2015-02-19 at 23:14 +0100, Michael Adam wrote:
> On 2015-02-20 at 10:02 +1300, Andrew Bartlett wrote:
> > On Wed, 2015-02-18 at 23:37 +0100, Michael Adam wrote:
> > >
> > > So if we were to test just one of the scenarios, I'd make a
> > > strong vote for the nss_winbind one.
> > 
> > We should test both.  We need to understand why they are different, and
> > we should not change the tests until we understand the tests.
> 
> Since the procedure now yields slightly different results,
> I don't see how to test both without changing the test.
> 
> > The difference may well be due to the different smb.conf files in use,
> > rather than anything more dramatic, when :local was added.  Can you
> > check?
> 
> There is no difference in smb.conf: This test was only ever run
> against the plugin_s4_dc:local env (56fd072fd).
> The only difference is the use of nss_winbindd via nsswrapper
> through the setting of a few env vars (14cbc791ee703).

Indeed, just reverting this part works. 

As discussed, I'm not happy to leave this as it is, and so in the
meantime I propose to revert the patch so we don't miss any other
unintentional changes in this area.

I'm sorry this has been so much drama.

Please review/push.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba



-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-selftest-re-enable-nss_winbind-via-nss_wrappe.patch
Type: text/x-patch
Size: 2069 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150302/a9480677/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: This is a digitally signed message part
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150302/a9480677/attachment.pgp>