[PATCH] [REVERT] Re: selftest: re-enable nss_winbind via nss_wrapper in the test-envs.
obnox at samba.org
Sun Mar 1 23:07:21 MST 2015
On 2015-03-02 at 13:44 +1300, Andrew Bartlett wrote:
> On Thu, 2015-02-19 at 23:14 +0100, Michael Adam wrote:
> > On 2015-02-20 at 10:02 +1300, Andrew Bartlett wrote:
> > > On Wed, 2015-02-18 at 23:37 +0100, Michael Adam wrote:
> > > >
> > > > So if we were to test just one of the scenarios, I'd make a
> > > > strong vote for the nss_winbind one.
> > >
> > > We should test both. We need to understand why they are different, and
> > > we should not change the tests until we understand the tests.
> > Since the procedure now yields slightly different results,
> > I don't see how to test both without changing the test.
> > > The difference may well be due to the different smb.conf files in use,
> > > rather than anything more dramatic, when :local was added. Can you
> > > check?
> > There is no difference in smb.conf: This test was only ever run
> > against the plugin_s4_dc:local env (56fd072fd).
> > The only difference is the use of nss_winbindd via nsswrapper
> > through the setting of a few env vars (14cbc791ee703).
> Indeed, just reverting this part works.
> As discussed, I'm not happy to leave this as it is, and so in the
> meantime I propose to revert the patch so we don't miss any other
> unintentional changes in this area.
> I'm sorry this has been so much drama.
> Please review/push.
NACK as discussed previously.
I just did not have the time to follow up on the coding yet.
Sorry for that!
This patch changes all environments, not just the one
used for that test, and we want to test nss_winbindd
in our environments, arguably also with.
And I thought that we meanwhile do have some other tests
that rely on this. Apparently not all of the other proposed
patches have made it into master. Possibly we lost track of
the actual patches by this sad discussion. I need to dig
throug the mails of the past months to see what has been
After all these changes were done as preparations for
some other changes.
So if we can do a patch that re-disables the exporting
of the nss-vars just for the pluging_s4_dc env or even
better just for this env and just for this test, then
I would not object.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 198 bytes
Desc: not available
More information about the samba-technical