[PATCH] Increase writetimeupdatedelay and sharedelay in Samba4.pm, remove winbind from Samba for 4.3

Michael Adam obnox at samba.org
Tue Jun 30 05:51:25 MDT 2015


On 2015-06-30 at 09:44 +0200, Michael Adam wrote:
> On 2015-06-30 at 19:07 +1200, Andrew Bartlett wrote:
> > On Tue, 2015-06-30 at 09:03 +0200, Michael Adam wrote:
> > > failed again - resubmitted
> > > 
> > > I get the impression that we should disable the defer_open
> > > test against the ad_dc_ntvfs env in order to be able
> > > complete any autobuild ... :-/
> > 
> > I'm happy with this course of action.  I don't understand why the
> > winbindd change broke this,
> 
> I guess it was this commit
> 45b7992428f646b8586974e1d86e3cdad869b059
> which changed the timings.
> 
> > but given the position of the ntvfs file
> > server, further time spent in this direction will just be wasted.
> 
> Attached find a patch that skips the
> base.defer_open test from planning in
> source4/selftest/test.py. Currently this
> only excludes it from ad_dc_ntvfs environments.
> But I am not sure if this is too coars or radical.
> 
> If this is deemed ok, then I would push it over
> my currently waiting autobuild to enhance the
> chances of landing.

Thinking about it ... I'd rather skip the tests for now
instead of removing them from planning.

Attached is an updated patch.

Michael
-------------- next part --------------
From 510a082890785216540848f5d988fceb603bed09 Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 30 Jun 2015 13:49:38 +0200
Subject: [PATCH] selftest: skip the ntvfs based base.defer_open tests

They have timing issues and the ntvfs is not the focus
of development.

Signed-off-by: Michael Adam <obnox at samba.org>
---
 selftest/skip | 1 +
 1 file changed, 1 insertion(+)

diff --git a/selftest/skip b/selftest/skip
index 7790594..94d0a88 100644
--- a/selftest/skip
+++ b/selftest/skip
@@ -103,6 +103,7 @@ bench # don't run benchmarks in our selftest
 ^samba4.*.base.delaywrite # This is randomly failing, depending on timing and filesystem features
 ^samba4.*.base.winattr
 ^samba4.*.base.birthtime
+^samba4.*base.defer_open
 ^samba4.smb2.acls # new test which doesn't pass yet
 # ktutil might not be installed or from mit...
 # we should build a samba4ktutil and use that instead
-- 
2.4.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150630/2dbd6b07/attachment.pgp>


More information about the samba-technical mailing list