[PATCH] Increase writetimeupdatedelay and sharedelay in Samba4.pm, remove winbind from Samba for 4.3

Michael Adam obnox at samba.org
Tue Jun 30 01:44:11 MDT 2015


On 2015-06-30 at 19:07 +1200, Andrew Bartlett wrote:
> On Tue, 2015-06-30 at 09:03 +0200, Michael Adam wrote:
> > failed again - resubmitted
> > 
> > I get the impression that we should disable the defer_open
> > test against the ad_dc_ntvfs env in order to be able
> > complete any autobuild ... :-/
> 
> I'm happy with this course of action.  I don't understand why the
> winbindd change broke this,

I guess it was this commit
45b7992428f646b8586974e1d86e3cdad869b059
which changed the timings.

> but given the position of the ntvfs file
> server, further time spent in this direction will just be wasted.

Attached find a patch that skips the
base.defer_open test from planning in
source4/selftest/test.py. Currently this
only excludes it from ad_dc_ntvfs environments.
But I am not sure if this is too coars or radical.

If this is deemed ok, then I would push it over
my currently waiting autobuild to enhance the
chances of landing.

Thanks - Michael
-------------- next part --------------
From 6a9372eb151679eb9eea9e90c012423f3c2f7a3f Mon Sep 17 00:00:00 2001
From: Michael Adam <obnox at samba.org>
Date: Tue, 30 Jun 2015 09:39:27 +0200
Subject: [PATCH] selftest: don't plan the base.defer_open test against a ntvfs
 based env

Signed-off-by: Michael Adam <obnox at samba.org>
---
 source4/selftest/tests.py | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/source4/selftest/tests.py b/source4/selftest/tests.py
index ff675ba..5b95e94 100755
--- a/source4/selftest/tests.py
+++ b/source4/selftest/tests.py
@@ -237,7 +237,7 @@ ntvfsargs = ["--option=torture:sharedelay=100000", "--option=torture:oplocktimeo
 smb2 = smbtorture4_testsuites("smb2.")
 #The QFILEINFO-IPC test needs to be on ipc$
 raw = filter(lambda x: "raw.qfileinfo.ipc" not in x, smbtorture4_testsuites("raw."))
-base = smbtorture4_testsuites("base.")
+base = filter(lambda x: "base.defer_open" not in x, smbtorture4_testsuites("base."))
 
 netapi = smbtorture4_testsuites("netapi.")
 
-- 
2.4.3

-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150630/ed0811e8/attachment.pgp>


More information about the samba-technical mailing list