[PATCH] Fix Bug 10991 after classicupgrade (winbindd failure to startup)

Jeremy Allison jra at samba.org
Wed Jun 17 10:10:02 MDT 2015


On Wed, Jun 17, 2015 at 12:12:17PM +0200, Volker Lendecke wrote:
> On Wed, Jun 17, 2015 at 10:09:45PM +1200, Andrew Bartlett wrote:
> > On Wed, 2015-06-17 at 12:00 +0200, Volker Lendecke wrote:
> > > On Wed, Jun 17, 2015 at 09:40:13PM +1200, Andrew Bartlett wrote:
> > > > > > Gna, s/autobuild/line length/. I fight with autobuild
> > > > > > failures too much :-)
> > > > > 
> > > > > Sure, I'll tidy that up, probably on Monday.
> > > > 
> > > > See attached.
> > > > 
> > > > Thanks!
> > > 
> > > After the patch source3/winbindd/winbindd_util.c:735 has 97
> > > characters. Can you fix that?
> > 
> > Is this better?
> 
> Yes. My apologies for not going through all the long lines in the patch. I
> think we should just drop the 80-column rule.  This seems too difficult
> to achieve.

Andrew,

If you put the following in your .vimrc file and open
a file with vim, you will see any trailing spaces as
red blocks, and any characters over the 80 column limit
as blocked in yellow.

This is what both Volker and I use to keep to these
limits.

Cheers,

	Jeremy.
-------------- next part --------------
set tabstop=8
set shiftwidth=8
set nowrap

if has("syntax") && (&t_Co > 2 || has("gui_running"))
       syntax on
       function! ActivateInvisibleCharIndicator()
               syntax match TrailingSpace "[ \t]\+$" display containedin=ALL
	       highlight TrailingSpace ctermbg=Red guibg=Red
       endf
       autocmd BufNewFile,BufRead * call ActivateInvisibleCharIndicator()
       autocmd BufNewFile,BufRead *.c highlight cCommentL ctermbg=Red guibg=Red
endif

au BufNewFile,BufRead *.c,*.h exec 'match Todo /\%>' .  80 .  'v.\+/'


More information about the samba-technical mailing list