[PATCH][WIP] Remove (internal) winbind from Samba for 4.3

Andrew Bartlett abartlet at samba.org
Fri Jun 12 03:01:36 MDT 2015


To those not on the team, or not at SambaXP, this might seem extreme :-)

What this patch does is remove the *internal* winbind from the source4
directory.  This was replaced by default with winbindd from source3 in
Samba 4.2, and this patch is to remove it.  Unlike other areas of
duplication, this has no redeeming features in my view, so now we have
fixed the classicupgrade issues (on which this patch builds), we can
remove it. 

I'm running private autobuilds to confirm I got the knownfail changes
correct, but in the meantime I want to ensure there is the opportunity
for reasonable discussion here.


Volker,

I know this is passion of yours, so I while I have the patch already
reviewed by Garming, I figure you may have a view, and in any case I
know this has been a concern to you personally, so you deserve the
honour of pushing it, if you want, once it is final.

 b/selftest/knownfail                   |   38 
 b/selftest/target/Samba4.pm            |   10 
 b/source3/winbindd/winbindd_util.c     |   41 
 b/source4/winbind/winbindd.c           |    6 
 b/source4/winbind/wscript_build        |    9 
 source4/winbind/wb_cmd_getdcname.c     |  133 --
 source4/winbind/wb_cmd_getgrent.c      |  124 --
 source4/winbind/wb_cmd_getgrgid.c      |  181 ---
 source4/winbind/wb_cmd_getgrnam.c      |  174 ---
 source4/winbind/wb_cmd_getgroups.c     |  223 ----
 source4/winbind/wb_cmd_getpwent.c      |  125 --
 source4/winbind/wb_cmd_getpwnam.c      |  208 ----
 source4/winbind/wb_cmd_getpwuid.c      |  213 ----
 source4/winbind/wb_cmd_list_groups.c   |  206 ----
 source4/winbind/wb_cmd_list_trustdom.c |  199 ----
 source4/winbind/wb_cmd_list_users.c    |  200 ----
 source4/winbind/wb_cmd_lookupname.c    |  121 --
 source4/winbind/wb_cmd_lookupsid.c     |  120 --
 source4/winbind/wb_cmd_setgrent.c      |  172 ---
 source4/winbind/wb_cmd_setpwent.c      |  177 ---
 source4/winbind/wb_cmd_userdomgroups.c |  148 ---
 source4/winbind/wb_cmd_usersids.c      |  197 ----
 source4/winbind/wb_connect_lsa.c       |  139 --
 source4/winbind/wb_connect_sam.c       |  172 ---
 source4/winbind/wb_dom_info.c          |  164 ---
 source4/winbind/wb_dom_info_trusted.c  |  244 ----
 source4/winbind/wb_gid2sid.c           |  100 --
 source4/winbind/wb_init_domain.c       |  485 ---------
 source4/winbind/wb_irpc.c              |  143 --
 source4/winbind/wb_name2domain.c       |  120 --
 source4/winbind/wb_pam_auth.c          |  291 -----
 source4/winbind/wb_sam_logon.c         |  243 ----
 source4/winbind/wb_samba3_cmd.c        | 1619 ---------------------------------
 source4/winbind/wb_samba3_protocol.c   |  377 -------
 source4/winbind/wb_server.c            |  410 --------
 source4/winbind/wb_server.h            |  194 ---
 source4/winbind/wb_sid2domain.c        |  327 ------
 source4/winbind/wb_sid2gid.c           |  109 --
 source4/winbind/wb_sid2uid.c           |  109 --
 source4/winbind/wb_sids2xids.c         |   96 -
 source4/winbind/wb_uid2sid.c           |  102 --
 source4/winbind/wb_update_rodc_dns.c   |  233 ----
 source4/winbind/wb_xids2sids.c         |   93 -

Finally, I know you are very interested in what we should do with the
NTVFS file server.  My view there is to put it behind a configure
switch, on for --enable-developer but off otherwise.  

The difference here is that NTVFS file server has features not found
elsewhere (a CIFS proxy) and provides an independent witness as to
changes in smbtorture that are matched in the smbd server.  By getting
it out of the default build, it avoids being built and avoids being part
of the security exposure for our vendors. 

I will propose a separate patch for this soon.

Andrew Bartlett

-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba


-- 
Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-winbindd-Remove-the-winbind-rewrite-from-the-samb.patch
Type: text/x-patch
Size: 285520 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150612/f97110fd/attachment-0001.bin>


More information about the samba-technical mailing list