[PATCH] More tdb/ldb tests.

[Andrew Bartlett]

On Fri, 2015-07-31 at 12:52 +1200, Adrian Cochrane wrote:
> This one took me a bit but this expands test coverage of tdb.

Thanks Adrian.  I really appriciate your efforts to lock in the
ldb_unpack_data behaviour. 

As you know, the next steps are to incorporate the
ldb_unpack_data_withlist patches from Matthieu, and then test those.

However, first I need you to fix up a few things.  Please read
README.Coding.  In particular please fix up the comments and use 8
-space tabs for indentation. 

For the ntSecurityDescriptor skip:
 - In the comment, explain that it can't round-trip via the SDDL string
(that's what the line-noise like string starting with O: is)
 - Please don't just write 'Skipping' as the output, either remove the
torture_comment or make it more meaningful.  I would prefer it removed
as it will happen every time in normal behaviour. 

Can you see if you can avoid using ldb_private.h?  There is only one
other place that it is used outside ldb, and that also appears to be a
bug (you are welcome to remove that as well :-).

Finally, the copyright in ldb_parse.h looks wrong.  I didn't write that
in 2008 :-).  I'll help you fix that up offline.

Thanks!

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba