[PATCH] More tdb/ldb tests.

[Stefan Metzmacher]

Hi Adrian,

> On Fri, 2015-07-31 at 12:52 +1200, Adrian Cochrane wrote:
>> This one took me a bit but this expands test coverage of tdb.
> 
> Thanks Adrian.  I really appriciate your efforts to lock in the
> ldb_unpack_data behaviour. 
> 
> As you know, the next steps are to incorporate the
> ldb_unpack_data_withlist patches from Matthieu, and then test those.
> 
> However, first I need you to fix up a few things.  Please read
> README.Coding.  In particular please fix up the comments and use 8
> -space tabs for indentation. 
> 
> For the ntSecurityDescriptor skip:
>  - In the comment, explain that it can't round-trip via the SDDL string
> (that's what the line-noise like string starting with O: is)
>  - Please don't just write 'Skipping' as the output, either remove the
> torture_comment or make it more meaningful.  I would prefer it removed
> as it will happen every time in normal behaviour. 

Would it be possible to check if it's possible to fix the SDDL translation
to avoid losing information?

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150731/56836af9/signature.sig>