[PATCH] correct order of include files to include replace.h first

[Uri Simchoni]

On Sat, Jul 11, 2015 at 12:24 PM, Thomas Nagy <tnagy at waf.io> wrote:
> On Wed, 8 Jul 2015 23:16:25 +0300, Uri Simchoni wrote:
>
>> Hi,
<snip>
>> 3/3 - a change to the build system to catch all those files in 2/3 -
>> This is a change to waf so I don't really expect it to be pushed
>> as-is, it's just an idea of what can be done to automate this check.
>
> Is !defined(SAMBA_CONFIG_NOT_FIRST) also meant for the sub-projects such as ctdb?
>
> Thomas

I've resubmitted without changing waf and without this
SAMBA_CONFIG_NOT_FIRST exception. If we were to change waf in order to
accommodate this, the rationale is to set a coding standard that
config.h comes before glibc files, but also to allow exceptions -
because this is not more than a convention that makes reasoning about
the code easier. If a plugin to samba includes headers from another
subsystem and there's some headers mess that can only resolved by
breaking the convention, and the code is still correct after breaking
the convention, then the convention should be allowed to be broken. On
a closed library with no plugins I would not allow exceptions.

Thanks,
Uri.