[PATCH] correct order of include files to include replace.h first

Thomas Nagy tnagy at waf.io
Sat Jul 11 09:24:54 UTC 2015


On Wed, 8 Jul 2015 23:16:25 +0300, Uri Simchoni wrote:

> Hi,
> 
> This is a re-submission of a patch series, because the previous
> submission was part of a thread and may have gone unnoticed.
> The patches change order of include files to make sure replace.h is
> included first. I am told this is the convention.
> 
> 1/3 - This is an actual bug fix, causing fcntl locking not to work in
> 32-bit x86.
> 2/3 - Fix order of includes in other files, to comply with the
> convention, but with no actual known bug that it fixes
> 3/3 - a change to the build system to catch all those files in 2/3 -
> This is a change to waf so I don't really expect it to be pushed
> as-is, it's just an idea of what can be done to automate this check.

Is !defined(SAMBA_CONFIG_NOT_FIRST) also meant for the sub-projects such as ctdb?

Thomas



More information about the samba-technical mailing list