[PATCH] correct order of include files to include replace.h first

Uri Simchoni urisimchoni at gmail.com
Wed Jul 8 20:16:25 UTC 2015


Hi,

This is a re-submission of a patch series, because the previous
submission was part of a thread and may have gone unnoticed.
The patches change order of include files to make sure replace.h is
included first. I am told this is the convention.

1/3 - This is an actual bug fix, causing fcntl locking not to work in
32-bit x86.
2/3 - Fix order of includes in other files, to comply with the
convention, but with no actual known bug that it fixes
3/3 - a change to the build system to catch all those files in 2/3 -
This is a change to waf so I don't really expect it to be pushed
as-is, it's just an idea of what can be done to automate this check.

Thanks,
Uri.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: fix_lfs.patch
Type: application/octet-stream
Size: 6646 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150708/352e21e8/fix_lfs.obj>


More information about the samba-technical mailing list