[PATCH] correct order of include files to include replace.h first

[Stefan (metze) Metzmacher]

Hi Uri,

> This is a re-submission of a patch series, because the previous
> submission was part of a thread and may have gone unnoticed.
> The patches change order of include files to make sure replace.h is
> included first. I am told this is the convention.
> 
> 1/3 - This is an actual bug fix, causing fcntl locking not to work in
> 32-bit x86.

Reviewed-by: me

> 2/3 - Fix order of includes in other files, to comply with the
> convention, but with no actual known bug that it fixes

Can you please split this patch? One commit per sub directory please.
This makes potential backporting easier. In some places you could
also try to remove the direct include of system headers, we should
try to use "system/*.h" instead of possible.

> 3/3 - a change to the build system to catch all those files in 2/3 -
> This is a change to waf so I don't really expect it to be pushed
> as-is, it's just an idea of what can be done to automate this check.

Why don't you fix source3/modules/vfs_btrfs.c
similar to the 2nd patch.

Instead of modifying third_party/waf/wafadmin/Tools/config_c.py,
I guess we can add somthing like this to lib/replace/replace.h.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150708/a072b631/signature.sig>