Your Tombstone Reanimation branch

[Kamen Mazdrashki]

Hi Garming,

On Fri, Jan 23, 2015 at 12:53 AM, Garming Sam <garming at catalyst.net.nz>
wrote:

> Hi Kamen,
>
> I've just looked into what caused the issue with the upgrade provision
> test. It looks like in the final patch, you managed to omit logonCount in
> the table of options.
>
> Many thanks for nailing down what the problem was!


> That should be a simple fix, but Andrew has suggested, if you don't mind,
> that a test should be written to explicity test the defaults. Preferably in
> sam.py.
>

The test needs to not only confirm that the bare minimum 'add' request
> works as expected (and asserts on the attributes added, and that no others
> are added), but also check that if each of the attributes is included in
> the add, that it either fails, or succeeds and replaces the default value.
>
> A bare minimum add is:
>
> dn: cn=testuser,cn=users,dc=samba,dc=org
> objectclass: user
>
> The same needs to be done for groups.
>
> That's a good idea.
For some reason, I thought there is already such test (or may I have
thought about it, hm)
I will make it tomorrow.

Meanwhile, please find attached:
1. updated last commit for adding missed 'logonCount'
2. extending the tests for restored objects so we also assert on some
expected values

Cheers,
Kamen

Cheers,
>
> Andrew and Garming
>
>
>
> On 23/01/15 09:46, Kamen Mazdrashki wrote:
>
>> HI Andrew,
>>
>> On Thu, Jan 22, 2015 at 11:58 AM, Andrew Bartlett <abartlet at samba.org>
>> wrote:
>>
>>  Kamen,
>>>
>>> I've pushed your branch, with review tags, to my repo as
>>> tombstone-reanimation-wip and to autobuild.
>>>
>>>  Thanks a lot!
>>
>>
>>  Thanks for all your patient work on this.  We may still want to clean
>>> this up a little (see attached tiny cleanup), but leaving the rest
>>> out-of-tree any longer is no longer helpful.
>>>
>>> Thanks for your patience to review it so many times :)
>>>
>> I totally agree with you patch - I thought we got this convention for
>> private
>> functions to be prefixed with _, but now I see it is outdated.
>>
>> I will look further for common tombstone/samldb functionality to extract
>> as you proposed. And also a patch for objectCategory windows-like
>> handling.
>>
>> Thanks,
>> Kamen
>>
>>
>>  Thanks,
>>>
>>> Andrew Bartlett
>>>
>>> --
>>> Andrew Bartlett                       http://samba.org/~abartlet/
>>> Authentication Developer, Samba Team  http://samba.org
>>> Samba Developer, Catalyst IT
>>> http://catalyst.net.nz/services/samba
>>>
>>>
>>>
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-s4-dsdb-Refactor-user-objects-defaults-setter-to-use.patch
Type: text/x-patch
Size: 2709 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150123/683c6348/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-s4-dsdb-tests-Assert-on-expected-set-of-attributes-f.patch
Type: text/x-patch
Size: 8010 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150123/683c6348/attachment-0001.bin>