[PATCH] New VFS Module "unityed_media" for sharing AVID projects

Ralph Böhme rb at sernet.de
Tue Jan 6 10:14:40 MST 2015

Hi Jeremy,

thanks for looking into this one!

On Mon, Jan 05, 2015 at 02:35:30PM -0800, Jeremy Allison wrote:
> > updated patch attached.
> Looks much better, but there's still some cruft
> in the pathname processing probably left over
> from the original code implementation.
> For example: is_in_media_dir() it looks for
> "./" and "../" - these are stripped out in
> source3/smbd/reply.c:check_path_syntax_internal()
> (and have been for may years :-).

Actually, I'm not so sure. I specifically asked a questino wrt to this
back in October:


I seem to remember that I most certainly saw paths starting with "./"
and the whole thing fell apart when I removed those extra checks from
the module.

> Ralph, do you want to fix these up before commit
> or do you want to do it later.

Well, if you ask: later! ;)

> If you've already got it working and tested, I don't want
> to delay adding the functionality, but we really
> should make new code a little more polished than
> some of the old stuff we have :-).

Yep, it's tested and working. And it already is quite polished, at
least compared to the original state it was in. :)

> Let me know what you'd like to do !

Push it! :)))


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list