[PATCH] New VFS Module "unityed_media" for sharing AVID projects
jra at samba.org
Tue Jan 6 10:19:14 MST 2015
On Tue, Jan 06, 2015 at 06:14:40PM +0100, Ralph Böhme wrote:
> Hi Jeremy,
> thanks for looking into this one!
> On Mon, Jan 05, 2015 at 02:35:30PM -0800, Jeremy Allison wrote:
> > > updated patch attached.
> > Looks much better, but there's still some cruft
> > in the pathname processing probably left over
> > from the original code implementation.
> > For example: is_in_media_dir() it looks for
> > "./" and "../" - these are stripped out in
> > source3/smbd/reply.c:check_path_syntax_internal()
> > (and have been for may years :-).
> Actually, I'm not so sure. I specifically asked a questino wrt to this
> back in October:
> I seem to remember that I most certainly saw paths starting with "./"
> and the whole thing fell apart when I removed those extra checks from
> the module.
That shouldn't happen of course :-). Can you remove
the checks once it's in and add abort() instead so
I can figure out where these things are coming from ?
> Push it! :)))
Ok, thanks - I'll finish looking today.
More information about the samba-technical