[PATCH] lib/util: Build iov_buf library only when building samba
martin at meltin.net
Thu Feb 26 22:38:50 MST 2015
On Thu, 26 Feb 2015 09:31:39 +0100, Michael Adam <obnox at samba.org>
> On 2015-02-26 at 08:30 +0100, Volker Lendecke wrote:
> > On Thu, Feb 26, 2015 at 11:52:48AM +1100, Amitay Isaacs wrote:
> > > Hi,
> > >
> > > Adding new libraries in lib/util at the wrong place in wscript breaks
> > > standalone ctdb rpm build.
> > Let's better revert this patch. Whenever I touch ANYTHING in
> > lib/ I step on someones toes. See the unresolved debug
> > desaster with OpenChange recently. I will send out reverts.
> Don't be silly... I can't imagine on who's toes you
> might have stepped. The only possible problem is that
> the standalone ctdb build is apparently not tested as
> well as it should be - not your fault.
> I think Amitay's patch is perfectly reasonable.
> Reviewed-by: /me
> I might push later if there are no further objections.
I've pushed this. It is the only simple solution we have right now.
Volker, please keep refactoring lib/util. I love your work! It is
more important than occasional RPM build breakage in CTDB. If
someone happens to break it again then we'll just quietly push a similar
fix to this one...
... until we get time to handle this issue properly. :-)
peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 173 bytes
Desc: OpenPGP digital signature
More information about the samba-technical