[PATCH] lib/util: Build iov_buf library only when building samba
Volker.Lendecke at SerNet.DE
Thu Feb 26 02:11:17 MST 2015
On Thu, Feb 26, 2015 at 09:31:39AM +0100, Michael Adam wrote:
> On 2015-02-26 at 08:30 +0100, Volker Lendecke wrote:
> > On Thu, Feb 26, 2015 at 11:52:48AM +1100, Amitay Isaacs wrote:
> > > Hi,
> > >
> > > Adding new libraries in lib/util at the wrong place in wscript breaks
> > > standalone ctdb rpm build.
> > Let's better revert this patch. Whenever I touch ANYTHING in
> > lib/ I step on someones toes. See the unresolved debug
> > desaster with OpenChange recently. I will send out reverts.
> Don't be silly... I can't imagine on who's toes you
> might have stepped. The only possible problem is that
> the standalone ctdb build is apparently not tested as
> well as it should be - not your fault.
This innocent change that was perfectly fine for Samba broke ctdb,
and very likely it also broke OpenChange who intimately depend on
the exact library structure in lib/util. We have too many external
dependencies in lib/util to make any change there. What we should do
instead is create a new library subdirectory with a very clear name like
lib/util-samba-internal or something like that.
> I think Amitay's patch is perfectly reasonable.
> Reviewed-by: /me
Nack. We can't know who else's build this change destroys.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical