[PATCH] Add Solaris ports as a tevent backend.

Jeremy Allison jra at samba.org
Thu Feb 12 21:43:22 MST 2015


On Thu, Feb 12, 2015 at 08:47:20PM -0500, Ira Cooper wrote:
> 
> At least make sure that both backends don't get the chance start, there's
> no excuse there.  It doesn't even change the code logic.

OK, it's a fair cop. I'll add that in :-).

>  I'm giving the code a deeper read... It's been, a good while since I last
> read it ;).

The only place we enumerate over the entire fd list
is when we're adding a new event - and it's the exact
same place that the epoll code has to do the same
thing (as epoll can't have the same fd twice in
the epoll event args either).

I just didn't want any bike shedding. I'm frustrated
at the amount of time it's taken this code to get in :-).


More information about the samba-technical mailing list