[PATCH] Add Solaris ports as a tevent backend.

Ira Cooper ira at samba.org
Thu Feb 12 18:47:20 MST 2015


On Thu, Feb 12, 2015 at 8:22 PM, Jeremy Allison <jra at samba.org> wrote:

> On Thu, Feb 12, 2015 at 07:21:38PM -0500, Ira Cooper wrote:
> > What happens if someone has epoll + Solaris ports?  I know that the
> Illumos
> > folks have been implementing various Linux syscalls...  (You have a
> #ifdef
> > that needs checking at least...)
>
> Let me know when they add that.
>
> I don't think it's worth even trying to get the logic for
> that right in the code until it actually exists.
>
> IMHO it's about as likely as Linux adding ports :-).
>

Look at the work they've done with lx brands... Seriously. :(

At least make sure that both backends don't get the chance start, there's
no excuse there.  It doesn't even change the code logic.


> > I'm going to say, you are going against part of the goal of a ports
> backend, by
> > traversing all the registered events.  The goal is not to have
> performance
> > scale with the number of registered events.  (Like the poll backend.)
>
> I'm not walking all the registered events. The port_associate_vals
> struct is a separate (doubly) linked list hung off a port event.
> Not the same thing.
>

 I'm giving the code a deeper read... It's been, a good while since I last
read it ;).

-Ira


More information about the samba-technical mailing list