[PATCH] Re: samba4.krb5.kdc failures

[Jelmer Vernooij]

On Sun, Feb 08, 2015 at 08:11:14AM +1300, Andrew Bartlett wrote:
> 
> On Fri, 2015-02-06 at 11:05 +1300, Andrew Bartlett wrote:
> > On Thu, 2015-02-05 at 21:55 +1300, Andrew Bartlett wrote:
> > > I'm aware that I appear to have introduced a new flapping test in the
> > > new samba4.krb5.dc.canon suite.  I've pushed a new version of this test
> > > with much better diagnostics, to understand why we get this occasional
> > > failure. 
> > > 
> > > Garming and I are also going to look into some of the other flapping
> > > tests, to reduce the noise and hopefully shed some light on what is
> > > going on here.
> > > 
> > > Andrew Bartlett
> > 
> > Attached are two patches:
> >  - one to fix what might be the cause of our FD leak
> >  - one to further improve the otherwise reviewed krb5-upn2 branch, to
> > give even better error messages on failure.
> > 
> > Please review.  (I'll re-push the first patch before and the second
> > patch on top of krb5-upn2)
> 
> The attached patches appear to resolve the issue, fix the FD leak and
> provide better diagnostics.  If I can get a review on these, I can push
> my krb5-upn3 branch to master, fix the flapping test and lock in an
> improved set of KDC semantics.

These LGTM. For all three:

Reviewed-By: Jelmer Vernooij <jelmer at samba.org>

Cheers,

Jelmer
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150207/ae91c6f6/attachment.pgp>