[PATCH] Re: samba4.krb5.kdc failures

Andrew Bartlett abartlet at samba.org
Sat Feb 7 12:11:14 MST 2015

On Fri, 2015-02-06 at 11:05 +1300, Andrew Bartlett wrote:
> On Thu, 2015-02-05 at 21:55 +1300, Andrew Bartlett wrote:
> > I'm aware that I appear to have introduced a new flapping test in the
> > new samba4.krb5.dc.canon suite.  I've pushed a new version of this test
> > with much better diagnostics, to understand why we get this occasional
> > failure. 
> > 
> > Garming and I are also going to look into some of the other flapping
> > tests, to reduce the noise and hopefully shed some light on what is
> > going on here.
> > 
> > Andrew Bartlett
> Attached are two patches:
>  - one to fix what might be the cause of our FD leak
>  - one to further improve the otherwise reviewed krb5-upn2 branch, to
> give even better error messages on failure.
> Please review.  (I'll re-push the first patch before and the second
> patch on top of krb5-upn2)

The attached patches appear to resolve the issue, fix the FD leak and
provide better diagnostics.  If I can get a review on these, I can push
my krb5-upn3 branch to master, fix the flapping test and lock in an
improved set of KDC semantics.


Andrew Bartlett

Andrew Bartlett                       http://samba.org/~abartlet/
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-auth-kerberos-Use-talloc_stackframe-to-avoid-memory-.patch
Type: text/x-patch
Size: 5462 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150208/1f59f7d4/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-torture-krb5-Do-not-do-post-recv-checks-if-the-packe.patch
Type: text/x-patch
Size: 1699 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150208/1f59f7d4/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-torture-krb5-Provide-a-generic-handler-to-catch-and-.patch
Type: text/x-patch
Size: 2024 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150208/1f59f7d4/attachment-0002.bin>

More information about the samba-technical mailing list