[PATCH] Patch for bug 11347

Jeremy Allison jra at samba.org
Mon Dec 21 22:20:13 UTC 2015


On Mon, Dec 21, 2015 at 09:22:50AM +0100, Ralph Boehme wrote:
> Hi!
> 
> Attached is a somewhat largish patchset for bug 11347.
> 
> The first 13 patches are mostly cleanup for the torture test and
> making sure the test not only works against Samba running on the same
> host but also against any remote server including the OS X SMB server.
> 
> Then comes a patch that adds a mapping EOVERFLOW to
> NT_STATUS_ALLOTTED_SPACE_EXCEEDED to errmap_unix. I need this because
> some SMB layer ftruncate requests have to be rejected with this NT
> error code.
> 
> Alernatively I could rewrite SMB_VFS_FTRUNCATE and its callers to
> return nt error codes, but that would be an ABI change which would
> prevent backports.
> 
> After this come the fixes to vfs_fruit and accompanying tests.
> 
> Please review and push if ok. Thanks!

LGTM with a minor change to get:

struct smb2_handle h = { 0 };

to compile on an older gcc with picky developer.

Pushed - thanks ! Now let's work on NTSTATUS-ifying
the VFS :-).



More information about the samba-technical mailing list