[PATCH] Patch for bug 11347
jra at samba.org
Mon Dec 21 18:42:43 UTC 2015
On Mon, Dec 21, 2015 at 09:22:50AM +0100, Ralph Boehme wrote:
> Attached is a somewhat largish patchset for bug 11347.
> The first 13 patches are mostly cleanup for the torture test and
> making sure the test not only works against Samba running on the same
> host but also against any remote server including the OS X SMB server.
> Then comes a patch that adds a mapping EOVERFLOW to
> NT_STATUS_ALLOTTED_SPACE_EXCEEDED to errmap_unix. I need this because
> some SMB layer ftruncate requests have to be rejected with this NT
> error code.
> Alernatively I could rewrite SMB_VFS_FTRUNCATE and its callers to
> return nt error codes, but that would be an ABI change which would
> prevent backports.
FYI. I'm reviewing this right now.
Personally, I think in master we should move the VFS to return
NT_STATUS error codes eventually, but that's a different patch
to improve our infrastructure (I haven't forgotten about Uri's
patch to move open to NTSTATUS also, it's just stuck in my
todo queue :-).
I'm OK with the EOVERFLOW -> NT_STATUS_ALLOTTED_SPACE_EXCEEDED
mapping in this case and to make this work with 4.3.x and
below, but longer term I think moving to NT_STATUS returns
would be the better solution.
But that is a patch for another day :-).
More information about the samba-technical