[PATCH] samba-tool 'user create' examples incorrect
jra at samba.org
Fri Dec 4 17:52:42 UTC 2015
On Sat, Nov 21, 2015 at 09:27:04AM +0000, Rowland Penny wrote:
> On 21/11/15 00:52, Michael Adam wrote:
> >On 2015-11-09 at 10:12 +0000, Rowland Penny wrote:
> >>Hi, the attached patch fixes a very small problem. If you run 'samba-tool
> >>user create --help' you get lines like this:
> >>samba-tool user add User5 passw5rd --nis-domain=samdom
> >>Note that it uses 'add' instead of 'create', the attached patch fixes this.
> >Thanks for the patch!
> >The intended change itself is good, but a few cosmetic comments:
> >- The patch changes line breaks in several places
> > where no other change is done. Please avoid that.
> > If you want to fix the formatting of the text,
> > that should be a separate patch
> >- In those places where you add line breaks,
> > you introduces some trailing spaces, which make
> > git am complain. Please avoid those:
> >$ git am /tmp/0001-samba-tool-user-create-examples-show-add-instead-of-.patch
> >Applying: samba-tool: user create examples show 'add' instead of 'create' Signed-off-by: Rowland Penny <repenny241155 at gmail.com>
> >/data/obnox/devel/samba/master-push.git/.git/rebase-apply/patch:14: trailing whitespace.
> >This command creates a new user account in the Active Directory domain.
> >/data/obnox/devel/samba/master-push.git/.git/rebase-apply/patch:18: trailing whitespace.
> >User accounts may represent physical entities, such as people or may be used as
> >/data/obnox/devel/samba/master-push.git/.git/rebase-apply/patch:19: trailing whitespace.
> >service accounts for applications. User accounts are also referred to as
> >/data/obnox/devel/samba/master-push.git/.git/rebase-apply/patch:23: trailing whitespace.
> >A user account enables a user to logon to a computer and domain with an
> >/data/obnox/devel/samba/master-push.git/.git/rebase-apply/patch:24: trailing whitespace.
> >identity that can be authenticated. To maximize security, each user should
> >warning: squelched 13 whitespace errors
> >warning: 18 lines add whitespace errors.
> >Cheers - Michael
> OK, new patch based on Michaels comments, just changed 'add' to 'create'
Sorry for the delay Rowland - pushed !
More information about the samba-technical