[PATCH] DRAFT: Add new test which covers force user bug

Jeremy Allison jra at samba.org
Thu Dec 10 00:18:02 UTC 2015

On Wed, Dec 09, 2015 at 11:29:28AM -0800, Jeremy Allison wrote:
> On Tue, Dec 08, 2015 at 04:50:33PM +0100, Robin Hack wrote:
> > Hi Andrew.
> > 
> > Thank you for your time.
> > 
> > New patch is attached.
> Pushed to master. Thanks a *LOT* Robin. Helping
> improve our tests is a thankless task and we're
> really glad to have you help us with it !

Spoke too soon :-(. Robin, your patch
breaks the test:

make test TESTS=samba3.local.nss

Fails with:

WARNING!: ../source4/torture/local/nss_tests.c:589: g1->gr_name was jra, expected jra-group: getgrent_r and getgrgid_r gave different results
WARNING!: ../source4/torture/local/nss_tests.c:679: Expression `torture_assert_group_equal(tctx, &grp[i], &grp2, "getgrent_r and getgrgid_r gave different results")' failed: ../source4/torture/local/nss_tests.c:679

Which I think is because of the addition
of the hunk:

@@ -1552,6 +1580,7 @@ pdbtest_wkn:x:$uid_pdbtest_wkn:$gid_everyone:pdbtest_wkn gecos:$prefix_abs:/bin/
        print GROUP "nobody:x:$gid_nobody:

in your patch. Can you investigate and
fix please ?



More information about the samba-technical mailing list