[PATCH] Renaming a printer fails in Printer Management Console

Garming Sam garming at catalyst.net.nz
Fri Aug 28 02:06:31 UTC 2015


This is patch (with some additional allocation checks) I wrote late last 
year that was somewhat forgotten about. It fixes bug 10770, which 
explains that Samba doesn't allow renaming of a printer using the F2 key.

What was missing was the info level 4 call of _spoolss_SetPrinter, and 
here I've just retrieved the old printer, filled it in and used the 
update_printer_call which takes struct info level 2. I previously tried 
removing some of the additional talloc calls, but it seemed more trouble 
than it was worth at the time with some parts freeing somewhat unexpectedly.

Please review and push.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-spoolss-handle-SetPrinter-for-info-level-4.patch
Type: text/x-patch
Size: 3041 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150828/f34e50c3/0001-spoolss-handle-SetPrinter-for-info-level-4.bin>

More information about the samba-technical mailing list