[PATCH] Renaming a printer fails in Printer Management Console

Jeremy Allison jra at samba.org
Mon Aug 31 20:55:24 UTC 2015

On Fri, Aug 28, 2015 at 02:06:31PM +1200, Garming Sam wrote:
> Hi,
> This is patch (with some additional allocation checks) I wrote late
> last year that was somewhat forgotten about. It fixes bug 10770,
> which explains that Samba doesn't allow renaming of a printer using
> the F2 key.
> What was missing was the info level 4 call of _spoolss_SetPrinter,
> and here I've just retrieved the old printer, filled it in and used
> the update_printer_call which takes struct info level 2. I
> previously tried removing some of the additional talloc calls, but
> it seemed more trouble than it was worth at the time with some parts
> freeing somewhat unexpectedly.
> Please review and push.
> https://bugzilla.samba.org/show_bug.cgi?id=10770

LGTM - pushed. It would be nice to add some client tests
for info level 4 call of _spoolss_SetPrinter.. (just
saying :-).



More information about the samba-technical mailing list