[PATCH] Prepare for additional PAC types

Andrew Bartlett abartlet at samba.org
Fri Aug 21 00:09:08 UTC 2015


On Thu, 2015-08-20 at 17:26 +0200, Heiko Wundram wrote:
> Hey,
> 
> Am 20.08.2015 16:46, schrieb G√ľnther Deschner:
> > could you please add some tests to this patchset, similar to the 
> > tests
> > you can find here:
> 
> will do (the patches I sent are already content-preserving for 
> UPN_DNS_INFO), but generally, is there ever a need to do a 
> layout-preserving "passthrough" (i.e. load and store) of UPN_DNS_INFO 
> 
> buffers not created by Samba (i.e. where the format isn't shortest 
> possible, and in upn/domain-order)? I couldn't think of that 
> situation, 
> but in case there is, this problem is a lot harder than the patch I 
> sent.

Yes, we should be able to pull and push the same blob, byte for byte. 

We prefer this standard as a way of ensuring we do not get the
marshalling wrong.  It also ensures signatures are preserved (where
applicable).

Thanks, 

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba








More information about the samba-technical mailing list