[PATCH][PYTHON] Fix replPropertyMetaData sort order for schema extension attributes
abartlet at samba.org
Mon Aug 3 02:53:41 UTC 2015
On Thu, 2015-07-30 at 15:47 +1200, Andrew Bartlett wrote:
> On Tue, 2015-07-28 at 16:37 +1200, Andrew Bartlett wrote:
> > Comment on the attached patches would be most welcome. I realise
> > that
> > the assertion that dbcheck no longer flaps is untested, but I have
> > pinned down one cause.
> > Details of the initial symptoms are here:
> > https://lists.samba.org/archive/samba/2015-June/192485.html
> > https://bugzilla.samba.org/show_bug.cgi?id=10973#c8
> Attached is a new patch for review. This adds tests and so fixes
> of the python integer checking.
> Andrew Bartlett
New patches for this are now at git://git.samba.org/abartlet/samba.git
This now includes tests by introducing this error into a the 4.1.0rc3
reference provision and confirming dbcheck finds and fixes it.
It also has fixes for our python integer handling, ensuring that we
give errors if a python integer won't fit into the C type of the PIDL
-generated structure it is representing.
Can I please have this reviewed into master?
Authentication Developer, Samba Team https://samba.org
Samba Development and Support, Catalyst IT
More information about the samba-technical