[PATCH][PYTHON] Fix replPropertyMetaData sort order for schema extension attributes
metze at samba.org
Tue Aug 4 05:41:57 UTC 2015
Am 03.08.2015 um 04:53 schrieb Andrew Bartlett:
> On Thu, 2015-07-30 at 15:47 +1200, Andrew Bartlett wrote:
>> On Tue, 2015-07-28 at 16:37 +1200, Andrew Bartlett wrote:
>>> Comment on the attached patches would be most welcome. I realise
>>> the assertion that dbcheck no longer flaps is untested, but I have
>>> pinned down one cause.
>>> Details of the initial symptoms are here:
>> Attached is a new patch for review. This adds tests and so fixes
>> of the python integer checking.
>> Andrew Bartlett
> New patches for this are now at git://git.samba.org/abartlet/samba.git
> This now includes tests by introducing this error into a the 4.1.0rc3
> reference provision and confirming dbcheck finds and fixes it.
> It also has fixes for our python integer handling, ensuring that we
> give errors if a python integer won't fit into the C type of the PIDL
> -generated structure it is representing.
> Can I please have this reviewed into master?
The first questions:
- Do we have a test that checks the objectClass sorting against the LDAP
(and passed against windows)?
- Please add BUG: https:... tags to the commit messages
We want to backport this at least to v4-3-test and v4-2-test, but
maybe also to v4-1-test...
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: OpenPGP digital signature
More information about the samba-technical