Incorrect file size returned in the Respond of "FILE_SUPERSEDE Create"

[Kenny Dinh]

The patch looks good to me.


I have been trying to verify the test case I wrote in
source4/torture/raw/open.c.

I have been following direction from
https://wiki.samba.org/index.php/Writing_Torture_Tests .

It wasn't clear if torture test in source3 or source4 should be updated.
Attached is my version of of smbtorture, I tried to run my test but I'm not
hitting the error using the un-patched code.  The file size returned seems
to be 0 on open supersede.  There are other parameters in the create
operation that I trying to play around to trigger the error case.




On Tue, Apr 28, 2015 at 2:44 PM, Jeremy Allison <jra at samba.org> wrote:

> On Tue, Apr 28, 2015 at 12:56:16PM -0700, Kenny Dinh wrote:
> > I'm working on adding the torture test.  I'll send an update when it is
> > ready.
>
> OK Kenny, as we're going to have to fix this in 4.2.next and 4.1.next
> because it's a nasty bug I couldn't resist :-) so I created a bug for this:
>
> https://bugzilla.samba.org/show_bug.cgi?id=11240
>
> and also quickly knocked up a torture test (as this is easily
> reproduced in SMB1 as well as SMB2).
>
> The first patch needs your 'Signed-off-by:' as this is
> your work.
>
> Can you take a look and see if this is OK for you ?
>
> If you write a torture test I'd also love to see it
> (as is always helps to get more people who know how
> to write torture tests) but this was a quick and easy
> one to do (and I know we're going to have to fix
> asap).
>
> Cheers,
>
>         Jeremy.
>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: supersede_torture
Type: application/octet-stream
Size: 4937 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150428/d97b69b9/attachment.obj>