Trying again at using the python samba_kcc
asn at samba.org
Tue Apr 21 06:15:05 MDT 2015
On Friday 17 April 2015 21:44:21 Douglas Bagnall wrote:
> > I've only had a quick look and read through the first set of changed
> > files.
> > Some superficial comments:
> > * please follow the style guidelines:
> > - no lines over 80 characters
> > - PEP8: spaces around equals signs
> > - PEP8 : empty line before first method in class definition, and two
> > empty lines between>
> > top level objects like classes
> > - PEP8: "not foo" rather than "foo == False"
> > - PEP8: Please use single-line summaries in docstrings, and document
> > parameters
> I believe we have addressed most of these style issue later in the
> patch series (though not the docstrings -- thanks for raising that).
> Nevertheless I am still not really pleased by the overall style.
I know it is a work in progress branch but there are a lot of commits which
should be squashed into the patches where the code has been introduced.
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
More information about the samba-technical