[PATCH] namecache: fix uninitialised pointer returns
Volker.Lendecke at SerNet.DE
Fri Sep 12 07:55:29 MDT 2014
On Fri, Sep 12, 2014 at 02:28:34PM +0200, David Disseldorp wrote:
> On Fri, 12 Sep 2014 14:14:33 +0200, Volker Lendecke wrote:
> > On Fri, Sep 12, 2014 at 01:11:00PM +0200, David Disseldorp wrote:
> > > asprintf_strupper_m() doesn't set *strp on error.
> > R-b my, but wouldn't it be better to convert this to
> > talloc_asprintf?
> Yes, that'd be nice in the long run. There are only a handful of
> remaining asprintf_strupper_m() callers, it looks like conversion to use
> talloc_asprintf_strupper_m() would be pretty trivial.
By the way, netbios names are size-limited. So it would be
perfectly possible to avoid allocation in namecache.c
overall, similar to what we do now with server_id_buf.
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de
More information about the samba-technical