[PATCH] namecache: fix uninitialised pointer returns

David Disseldorp ddiss at suse.de
Fri Sep 12 06:28:34 MDT 2014

On Fri, 12 Sep 2014 14:14:33 +0200, Volker Lendecke wrote:

> On Fri, Sep 12, 2014 at 01:11:00PM +0200, David Disseldorp wrote:
> > asprintf_strupper_m() doesn't set *strp on error.  
> R-b my, but wouldn't it be better to convert this to
> talloc_asprintf?

Yes, that'd be nice in the long run. There are only a handful of
remaining asprintf_strupper_m() callers, it looks like conversion to use
talloc_asprintf_strupper_m() would be pretty trivial.

Cheers, David

More information about the samba-technical mailing list