change --picky-developer into --non-picky-developer
Stefan (metze) Metzmacher
metze at samba.org
Fri Oct 31 04:48:38 MDT 2014
Am 31.10.2014 um 11:43 schrieb Andrew Bartlett:
> On Thu, 2014-10-30 at 11:20 +0100, Stefan (metze) Metzmacher wrote:
>> Am 30.10.2014 um 11:10 schrieb Stefan (metze) Metzmacher:
>>> Hi Jelmer,
>>>>>> Ok, I fixed up
>>>>> That looks better, and I'll keep looking over it. Garming fixed some of
>>>>> the same things in loadparm in his patch set, and I would like to get
>>>>> this rebased on his changes, and both sets into master.
>>>> Can we make it --lenient-developer rather than --non-picky-developer ?
>>> What about --disable-Werror ?
>> Wireshark has:
>> treat warnings as errors (only for GCC or clang)
>> [default=yes, unless extra compiler warnings are
>> We could use --disable-warnings-as-errors ?
>> Or just make use --disable-Werror
> I'm ok with --disable-warnings-as-errors, it makes no implication on the
> developer just because they run a non-normative system.
Ok, I'll change it to --disable-warnings-as-errors.
> In terms of the rest of the patch, when I reviewed it last time, the
> remaining patches were those that traded style or clarity for a warning,
> or were not totally obvious as to what the change was. I need to look
> over it again, naturally.
> Taken one at a time, the cure often feels worse than the illness but I
> also accept that while these cases are not bugs, warnings can find bugs.
> I also agree that the most subtle bugs lurk in code that *looks* correct
> and sensible, and that warnings are too often overlooked.
Yes, we should notice when warnings are added.
> I certainly hope we can work something out here, so that we both improve
> our code and prevent regressions.
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 181 bytes
Desc: OpenPGP digital signature
More information about the samba-technical