change --picky-developer into --non-picky-developer
abartlet at samba.org
Fri Oct 31 04:43:04 MDT 2014
On Thu, 2014-10-30 at 11:20 +0100, Stefan (metze) Metzmacher wrote:
> Am 30.10.2014 um 11:10 schrieb Stefan (metze) Metzmacher:
> > Hi Jelmer,
> >>>> Ok, I fixed up
> >>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master4-picky
> >>> That looks better, and I'll keep looking over it. Garming fixed some of
> >>> the same things in loadparm in his patch set, and I would like to get
> >>> this rebased on his changes, and both sets into master.
> >> Can we make it --lenient-developer rather than --non-picky-developer ?
> >> :-)
> > What about --disable-Werror ?
> Wireshark has:
> treat warnings as errors (only for GCC or clang)
> [default=yes, unless extra compiler warnings are
> We could use --disable-warnings-as-errors ?
> Or just make use --disable-Werror
I'm ok with --disable-warnings-as-errors, it makes no implication on the
developer just because they run a non-normative system.
In terms of the rest of the patch, when I reviewed it last time, the
remaining patches were those that traded style or clarity for a warning,
or were not totally obvious as to what the change was. I need to look
over it again, naturally.
Taken one at a time, the cure often feels worse than the illness but I
also accept that while these cases are not bugs, warnings can find bugs.
I also agree that the most subtle bugs lurk in code that *looks* correct
and sensible, and that warnings are too often overlooked.
I certainly hope we can work something out here, so that we both improve
our code and prevent regressions.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical