Current SMB2 leases patchset (WIP).

Stefan (metze) Metzmacher metze at
Thu Oct 30 22:59:21 MDT 2014

Am 30.10.2014 um 20:10 schrieb Jeremy Allison:
> On Thu, Oct 30, 2014 at 04:33:49PM +0100, Stefan (metze) Metzmacher wrote:
>> Hi Jeremy,
>> one more...
>>> here's a first independent patchset set that can go to master now.
>>> Mostly the strict rename patches.
>>> The rest of the patches is in the following branch:
>>> I'll post more review details on the rest once I looked at it more closely.
>>> metze
> OK, I've pushed the previous patchset + this one
> to master.
> Attached is the rebase of my leases-wip patches
> remaining on top, just so I can keep working on
> it and ensure the logic hasn't changed :-).
> I'll accept more fixes to push as you get done
> with them !
> Thanks for doing this metze. I appreciate the
> work you're putting into it (and I noticed and
> adopted a fix you already did in your wip tree,
> removing the superfluous del_share_mode()
> call if grant_fsp_oplock_type() fails in open.c).
> That kind of thing is why I appreciate your
> careful review.

I think for such an important topic it's required
to review very careful. Not only because of the new leases feature
(which is disabled by default), but also avoid unnoticed changes to the
oplock logic.

> I know I'm grumpy about *how* you're doing it,
> but I think that's more the difference in yours
> and my work-styles with git than anything else.
> Michael tried to tell me my use of git was just
> "wrong", but I prefer "different" :-). After all,
> there's no one way to use git :-) :-) :-).



-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: OpenPGP digital signature
URL: <>

More information about the samba-technical mailing list