[PATCH] samba-tool: Adding/removing none-existent users to/from groups doesn't fail

Michael Adam obnox at samba.org
Thu Oct 23 08:17:12 MDT 2014


On 2014-10-18 at 02:23 +0200, Marc Muehlfeld wrote:
> Am 18.10.2014 um 01:47 schrieb Michael Adam:
> >> Do I understand this test right, when I think, that it creates 
> >> accounts and then tries to add (other) non existend accounts to
> >> the groups? In that case, my enhancement did what it should - it
> >> prints an error and quit. :-)
> > 
> > Your analysis seems perfectly correct: your improvement has 
> > uncovered an error in the test. The names were apparently intended
> > to be the same (creating and adding).
> > 
> >> Is this correct? Then I would try to fix the test.
> > 
> > Yeah, please!
> 
> Attached a patch for the test.

Pushed.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141023/6181c830/attachment.pgp>


More information about the samba-technical mailing list