[PATCH] samba-tool: Adding/removing none-existent users to/from groups doesn't fail

Marc Muehlfeld mmuehlfeld at samba.org
Fri Oct 17 18:23:37 MDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 18.10.2014 um 01:47 schrieb Michael Adam:
>> Do I understand this test right, when I think, that it creates 
>> accounts and then tries to add (other) non existend accounts to
>> the groups? In that case, my enhancement did what it should - it
>> prints an error and quit. :-)
> 
> Your analysis seems perfectly correct: your improvement has 
> uncovered an error in the test. The names were apparently intended
> to be the same (creating and adding).
> 
>> Is this correct? Then I would try to fix the test.
> 
> Yeah, please!

Attached a patch for the test.


Regards,
Marc
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQEcBAEBAgAGBQJUQbMCAAoJEFNERvHO3m515iAIAJXvhY3SLkzhEaWmGqSwDAOg
FD656NRBO8P4YlIXS1N+702acrZ1A+NOU//12wquWymmhyDRGUe1hIT8QGa8gLDs
r1QXhkueqE+7CMadV/E0Sd7Gb1EaBFc4FA3jdg1DncSDieBB9kj5kDQWLZFDcOfJ
sOee+tVCm4xZxWX7WhqkQ2ioSP9NTmUhNTioIQt506cd1POTDmShzUyLssYfWa6x
0SG/somQVBkiMaYG5W0hjzS+F/voQd72OTpjPOGeQp35Zq3BgMepRpsr7mvGyecu
IF570vQ2DfoE73ibk/VFpmTiQqDdyXmZVTe1IDFwRYGrr010qYVTLPwKOeBR10s=
=BmSP
-----END PGP SIGNATURE-----
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-test-samba4.blackbox.group.py.patch
Type: text/x-patch
Size: 3481 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141018/32b9fd36/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-test-samba4.blackbox.group.py.patch.sig
Type: application/pgp-signature
Size: 287 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141018/32b9fd36/attachment.pgp>


More information about the samba-technical mailing list