[PATCHES] Unified build for Samba and CTDB

Michael Adam obnox at samba.org
Thu Oct 9 01:32:12 MDT 2014


Hi Martin,

I just wanted to review/test your patches.
Then I noticed they have already been pushed (by Andrew).

Great stuff!

Next question is whether to enable cluster-support
by default in the build. I'd like to, but for that we'd
probably need a way to detect whether the system supports
building CTDB, which afaik current means Linux and possibly AIX.

Cheers - Michael

On 2014-10-08 at 13:30 +1100, Martin Schwenke wrote:
> 2 CTDB patches and 1 patch to the top-level Samba build:
> 
> 1. ctdb-build: Rename define BINDIR to CTDB_HELPER_BINDIR
> 
>    CTDB only uses BINDIR to decide where to put the lock/event
>    helpers.  This change stops it fighting with dynconfig over BINDIR.
> 
> 2. ctdb-build: Make some steps conditional on standalone build
> 
>    Some things in ctdb/wscript should only be done when doing a
>    standalone build.  They shouldn't be done when doing a Samba build.
> 
> 3. build: Hook CTDB into top level build using --with-cluster-support
> 
>    This seems like a reasonable way of getting CTDB built too.  If this
>    isn't the best way then please yell.  ;-)
> 
> Please review and push if OK.
> 
> These patches are in my ctdb-unified-build branch:
> 
>   http://git.samba.org/?p=martins/samba.git;a=shortlog;h=refs/heads/ctdb-unified-build
> 
> peace & happiness,
> martin


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20141009/2555a65b/attachment.pgp>


More information about the samba-technical mailing list