[PATCH] resolver: do not use stack allocated variables

Matthieu Patou mat at samba.org
Wed Oct 1 01:36:20 MDT 2014

On Tue, Sep 30, 2014 at 08:37:49AM +0200, Volker Lendecke wrote:
> On Mon, Sep 29, 2014 at 05:52:47PM -0700, Matthieu Patou wrote:
> > Hello,
> > 
> > Please find the attached patch.
> > 
> > Can someone review it ?
> It certainly is ok and matches our "normal" calling
> convention. However, in this particular case I see
> c->status = nbt_name_dup(state, name, &state->name);
> in resolve_name_all_send(). What triggered this patch? Did
> it crash somewhere?
> Thanks,
> Volker
So the patch dates from last year at IO Lab, we had some strange
behavior with the Windows Samba not able to join 2008R2 domains, Metze
and I found that some DNS records where corrupted and I think that Metze
proposed this patch. So no crash but an incorrect behavior definitely.


Matthieu Patou
Samba Team

More information about the samba-technical mailing list