[PATCH 00/11] libcli/security duplicate code removal

David Disseldorp ddiss at samba.org
Wed May 28 16:09:35 MDT 2014


This patch set continues on from the previous, removing more
duplicate and unused security descriptor handling code.

--

The following changes since commit 8605564f41f8f87dc4f2777294fb5abd9285e6e0:

  s3/profiles: improve copy_registry_tree() errors (2014-05-28 20:18:21 +0200)

are available in the git repository at:

  git://git.samba.org/ddiss/samba.git rm_dup_sd_code_redux

for you to fetch changes up to 6c7136eb7dba5c288b560479a27296ab7b15d0e7:

  libcli/security: remove sec_ace_equal (2014-05-29 00:01:12 +0200)

----------------------------------------------------------------
David Disseldorp (11):
      libcli/security: clean up and fix make_sec_desc
      libcli/security: remove dup_sec_acl()
      libcli/security: remove unused sec_desc_del_sid()
      libcli/security: remove unused sec_ace_del_sid()
      libcli/security: cleanup security_ace_equal()
      s3/libsmb_xattr: use security_ace_equal instead of sec_ace_equal
      s3/sharesec: use security_ace_equal instead of sec_ace_equal
      s3/smbcacls: use security_ace_equal instead of sec_ace_equal
      torture/attr: use security_ace_equal instead of sec_ace_equal
      secdesc: use security_ace_equal instead of sec_ace_equal
      libcli/security: remove sec_ace_equal

 libcli/security/secace.c              |  64 ----------------------------------------------------------------
 libcli/security/secace.h              |   2 --
 libcli/security/secacl.c              |  12 ------------
 libcli/security/secacl.h              |   1 -
 libcli/security/secdesc.c             | 112 ++++++++++++++++++++++++++++++----------------------------------------------------------------------------------
 libcli/security/secdesc.h             |   4 ----
 libcli/security/security_descriptor.c |  28 ++++++++++++++++++++--------
 source3/libsmb/libsmb_xattr.c         |   9 +++++----
 source3/utils/sharesec.c              |   8 +++++---
 source3/utils/smbcacls.c              |   9 +++++----
 source4/torture/basic/attr.c          |   6 +++---
 11 files changed, 68 insertions(+), 187 deletions(-)



More information about the samba-technical mailing list