[PATCH] CTDB - Make natgwlist and lvsmaster more resilient

[Martin Schwenke]

Recent changes have caused these commands to attempt to get
capabilities from all nodes before doing further filtering.  This
means that capabilities are unnecessarily fetched from nodes that are
unlikely to be the master.  If such a node does not answer the control
then many nodes can fail to calculate the master node.  In the case of
natgwlist this will cause "monitor" events to fail resulting in
unhealthy nodes.

Restore the behaviour where capabilities are only fetched for a node
that will be the master if it has the desired flags.

Although this masks a problem where a connected node is not replying,
it can help to avoid an outage in some cases.

Add supporting tests and infrastructure.  Infrastructure just lets a
timeout be faked - just for ctdb_ctrl_getcapabilities_stub() so far.
First test checks that this infrastructure works if the first node
times out in natgwlist.  Second test checks the case worked around by
the above fix - that is, no failure when a node with PNN beyond the
NATGW master can time out.

Please review and push if OK.

This patch is in my ctdb branch:

  http://git.samba.org/?p=martins/samba.git;a=shortlog;h=refs/heads/ctdb

peace & happiness,
martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ctdb-tools-ctdb-Make-natgwlist-and-lvsmaster-more-re.patch
Type: text/x-patch
Size: 9523 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140528/3163bb80/attachment.bin>