[PATCH] s4-dns: dlz_bind9: Fix ipv6 updates

[Günter Kukkukk]

Am 18.05.2014 06:48, schrieb Günter Kukkukk:
> Am 17.05.2014 18:44, schrieb Arvid Requate:
>> The attached patch fixes a bug in the dlz_bind9 module which caused updates of 
>> existing AAAA records to fail.
>>
>> b9_record_match did a plain string comparison, not taking into account the 
>> different representations of IPv6 addresses. In this case bind9 sends the 
>> record without zero padding, but ndr_pull from the LDB backend retrieves a 
>> zero padded representation. Since they don't match literally, updates failed 
>> ("deleting rrset" -> "cancelling transaction").
>>
>> Please review/push.
>>
>> Thanks,
>> Arvid
>>
> 
> Nice catch! Add my
> 
> Signed-off-by: Guenter Kukkukk <kukks at samba.org>

Sorry

Reviewed-by: Guenter Kukkukk <kukks at samba.org>

> 
> but please also correct the error string in the same switch()
> ...
> 	default:
> 		state->log(ISC_LOG_ERROR, "samba b9_putrr: unhandled record type %u",
> 			   rec1->wType);
> 		break;
> ...
> Should read:
> 		state->log(ISC_LOG_ERROR, "samba_dlz: b9_record_match - unhandled record type %u",
> 			   rec1->wType);
> 
> Cheers, Günter
> 


--