[PATCH] s4-dns: dlz_bind9: Fix ipv6 updates

Günter Kukkukk linux at kukkukk.com
Sat May 17 22:48:28 MDT 2014

Am 17.05.2014 18:44, schrieb Arvid Requate:
> The attached patch fixes a bug in the dlz_bind9 module which caused updates of 
> existing AAAA records to fail.
> b9_record_match did a plain string comparison, not taking into account the 
> different representations of IPv6 addresses. In this case bind9 sends the 
> record without zero padding, but ndr_pull from the LDB backend retrieves a 
> zero padded representation. Since they don't match literally, updates failed 
> ("deleting rrset" -> "cancelling transaction").
> Please review/push.
> Thanks,
> Arvid

Nice catch! Add my

Signed-off-by: Guenter Kukkukk <kukks at samba.org>

but please also correct the error string in the same switch()
		state->log(ISC_LOG_ERROR, "samba b9_putrr: unhandled record type %u",
Should read:
		state->log(ISC_LOG_ERROR, "samba_dlz: b9_record_match - unhandled record type %u",

Cheers, Günter

More information about the samba-technical mailing list