[PATCH] provision: Correctly provision the SOA record minimum TTL

Kai Blin kai at samba.org
Fri May 16 10:34:34 MDT 2014


This fixes bug #10466

Signed-off-by: Kai Blin <kai at samba.org>
---
 python/samba/provision/sambadns.py | 1 +
 python/samba/tests/dns.py          | 1 +
 2 files changed, 2 insertions(+)

diff --git a/python/samba/provision/sambadns.py b/python/samba/provision/sambadns.py
index 13e03ab..f1cb1e2 100644
--- a/python/samba/provision/sambadns.py
+++ b/python/samba/provision/sambadns.py
@@ -130,6 +130,7 @@ class SOARecord(dnsp.DnssrvRpcRecord):
         soa.expire = expire
         soa.mname = mname
         soa.rname = rname
+        soa.minimum = minimum
         self.data = soa
 
 
diff --git a/python/samba/tests/dns.py b/python/samba/tests/dns.py
index 9c0b274..5dc3d1f 100644
--- a/python/samba/tests/dns.py
+++ b/python/samba/tests/dns.py
@@ -289,6 +289,7 @@ class TestSimpleQueries(DNSTest):
         self.assert_dns_rcode_equals(response, dns.DNS_RCODE_OK)
         self.assert_dns_opcode_equals(response, dns.DNS_OPCODE_QUERY)
         self.assertEquals(response.ancount, 1)
+        self.assertEquals(response.answers[0].rdata.minimum, 3600)
 
 
 class TestDNSUpdates(DNSTest):
-- 
1.9.1



More information about the samba-technical mailing list