[PATCH] messaging3 improvements
jra at samba.org
Wed May 7 15:53:36 MDT 2014
On Wed, May 07, 2014 at 11:51:03PM +0200, Stefan (metze) Metzmacher wrote:
> Hi Jeremy,
> >> Yes, the tevent_req_defer_callback() is correct now.
> >> But I just noticed that messaging_defer_callback_trigger() doesn't
> >> cleanup 'state'.
> > Done.
> >> And it would be nice to use a helper variable in poll_funcs_fde_handler()
> >> instead of passing poll_events_to_tevent() as argument to w->callback().
> > and done.
> > Bear in mind I haven't reviewed myself yet
> > to fully understand what's being done, I'm just doing
> > the cleanups for Volker as he's travelling right now :-).
> > Let me know if this is ok.
> I think it's ok, but this is tricky code and it would be good
> if Volker and you also think my proposed changes are correct.
Ok, don't worry I'm not planning to push until
I've also reviewed this code and understand *exactly*
what it's doing (which is fun, as it's complex Volker code :-).
> I'm always a bit nervous when doing anything after calling a callback
> as it might destroy all context. So please think carefully about
Yeah, I was a little nervous about that TALLOC_FREE,
but otherwise it hangs around on the messaging context
which is bad, so... :-).
I'm still carefully reviewing !
More information about the samba-technical