[PATCH] messaging3 improvements

Stefan (metze) Metzmacher metze at samba.org
Wed May 7 15:51:03 MDT 2014

Hi Jeremy,

>> Yes, the tevent_req_defer_callback() is correct now.
>> But I just noticed that messaging_defer_callback_trigger() doesn't
>> cleanup 'state'.
> Done.
>> And it would be nice to use a helper variable in poll_funcs_fde_handler()
>> instead of passing poll_events_to_tevent() as argument to w->callback().
> and done.
> Bear in mind I haven't reviewed myself yet
> to fully understand what's being done, I'm just doing
> the cleanups for Volker as he's travelling right now :-).
> Let me know if this is ok.

I think it's ok, but this is tricky code and it would be good
if Volker and you also think my proposed changes are correct.

I'm always a bit nervous when doing anything after calling a callback
as it might destroy all context. So please think carefully about


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 263 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20140507/23510149/attachment.pgp>

More information about the samba-technical mailing list