[PATCH] Make loadparm more common

Andrew Bartlett abartlet at samba.org
Mon Mar 31 22:21:02 MDT 2014

On Mon, 2014-03-31 at 11:46 +0200, Andreas Schneider wrote:
> On Friday 28 March 2014 13:42:02 Andrew Bartlett wrote:
> > Even more patches are at
> > http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/loadpa
> > rm-talloc-to-review3
> > 
> > Please review!
> No! I've reviewed this patchset 3 or 4 times now. You constantly keep changing 
> and adding patches. I will not waste more time on reviewing stuff which is 
> still WIP and not tested.

I can understand your frustration.  As with other large patch sets, what
appears to be OK can have other issues when further investigated.  

The patch set at
http://git.catalyst.net.nz/gitweb?p=samba.git;a=shortlog;h=refs/heads/loadparm-talloc-to-review4 not only passes a full autobuild, it has passed a more limited test on each and every commit.

One of the big challenges with this patch set is that many issues have
shown up that are not present at the end, but which would impede a
bisect into the series later.  I've been working hard over the past few
days to address both these and other issues that showed up in a full
autobuild, but not in the expanded docs.py test that we aimed
specifically at this under-tested area of code.

> I will not start guessing which 55 patches are ready for master and pick them 
> out of the tree, that is your task.

At this point, what I would like to see is these patches reviewed:

Getting these reviewed should allow the set that was previously reviewed
by you and others to be merged, because gerrit should, if we are lucky,
pick them up as a trivial rebase.  Getting those marked out onto the
patches will hopefully temper a little of the remaining frustration,
because I agree re-reviewing patches again and again just isn't fun. 

> I'm will review patches if you have a clean tree for me which can really be 
> pushed at the end ...

While further testing may again reveal issues, I expect that
loadparm-talloc-to-review4 is such a tree. 


Per our discussion today, see above for the patches I was particularly
looking for you OK on.


Andrew Bartlett

Andrew Bartlett
Authentication Developer, Samba Team  http://samba.org
Samba Developer, Catalyst IT          http://catalyst.net.nz/services/samba

More information about the samba-technical mailing list